Fix(expandable): glitching animated expansion #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabric-ds@fd69c9a removed base styles which is needed when using element-collapse. Basically not have a `overflow: hidden` and `height: 0px`, makes it have default values causing the glitching effect. However when in default expanded mode, these styles must not be there. Closes fabric-ds/issues#108 fabric-ds#144
BalbinaK
approved these changes
Sep 26, 2022
digitalsadhu
approved these changes
Sep 26, 2022
Co-authored-by: Richard Walker <digitalsadhu@gmail.com>
BalbinaK
changed the title
BalbinaK
added a commit
that referenced
this pull request
Sep 28, 2022
BalbinaK
added a commit
that referenced
this pull request
Sep 28, 2022
|
🎉 This PR is included in version 1.4.2-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fd69c9a removed base styles which is needed when using element-collapse. Basically not have a
overflow: hiddenandheight: 0px, makes it have default values causing the glitching effect.However when in default expanded mode, these styles must not be there.
Closes
fabric-ds/issues#108
#144
If there is a simpler solution, please apply it! 😁 At least this does seem to work.