This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Support force_pull for /api/token when retrieving cluster tokens #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexeykazakov snapshot fabric8-auth image is available for testing. |
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 55.45% 55.59% +0.13%
==========================================
Files 71 71
Lines 6971 6992 +21
==========================================
+ Hits 3866 3887 +21
Misses 2788 2788
Partials 317 317
Continue to review full report at Codecov.
|
sbose78
reviewed
Feb 27, 2018
| "for": forResource, | ||
| "configuration_username": osConfig.OSOCluster().ServiceAccountUsername, | ||
| "user_profile_username": userProfile.Username, | ||
| }, "username from user profile for cluster token does not match username stored in configuration") |
There was a problem hiding this comment.
this is going to be a tricky situation, if this ever happens :)
sbose78
approved these changes
Feb 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we support force_pull param in /api/token?for=<oso_resource> endpoint when retrieving user OSO tokens.
This PR also adds support of the same force_pull param for cluster tokens too. Not only for user tokens.
When force_pull=true the auth service will load the user profile using the stored dsaas user token. It will return 401 if the token is not valid and rejected by OSO.
Required for openshiftio/openshift.io#2304