This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
expose Register func #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make this func usable from outside of the package as it is fairly generic. Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
dipak-pawar
approved these changes
May 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
======================================
Coverage 66.5% 66.5%
======================================
Files 32 32
Lines 1424 1424
======================================
Hits 947 947
Misses 401 401
Partials 76 76
Continue to review full report at Codecov.
|
| @@ -107,7 +107,8 @@ func registerMetrics(service string, opts ...BucketOption) { | |||
| log.Info(nil, nil, "metrics registered successfully") | |||
| } | |||
|
|
|||
| func register(c prometheus.Collector, name string) prometheus.Collector { | |||
| // Register registers the given collector | |||
| func Register(c prometheus.Collector, name string) prometheus.Collector { | |||
There was a problem hiding this comment.
overall, Register() func looks tiny to be reused.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make this func usable from outside of the package
as it is fairly generic.
Signed-off-by: Xavier Coulon xcoulon@redhat.com