This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
WIP: Addressing findings from linters/checkers/ci #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alien-ike
changed the title
alien-ike
changed the title
controller/space_test.go:85:23: cannot use client (type *http.Client) as type "context".Context in argument to deleteCodebases: *http.Client does not implement "context".Context (missing Deadline method) have http.deadline() time.Time want Deadline() (time.Time, bool) controller/space_test.go:85:23: cannot use config (type *configuration.Registry) as type *http.Client in argument to deleteCodebases controller/space_test.go:85:23: cannot use ctx (type "context".Context) as type *configuration.Registry in argument to deleteCodebases
…e untyped int as key in context.WithValue
kwk
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to keep our code clean and be able to block a PR on future issues that come up. Currently there are way too many issues. If we can address each single one of them, we can truly leverage the checkers.