This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
WIP: cascading soft delete #2324
Open
kwk
wants to merge
16
commits into
fabric8-services:master
Choose a base branch
from
kwk:cascaded-soft-deletes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2324 +/- ##
==========================================
- Coverage 70.17% 69.99% -0.18%
==========================================
Files 171 171
Lines 16625 16610 -15
==========================================
- Hits 11666 11626 -40
- Misses 3829 3861 +32
+ Partials 1130 1123 -7
Continue to review full report at Codecov.
|
kwk
force-pushed
the
cascaded-soft-deletes
branch
from
October 24, 2018 07:06
cb7487f
to
69e24a6
Compare
kwk
force-pushed
the
cascaded-soft-deletes
branch
from
October 25, 2018 09:07
69e24a6
to
7854b21
Compare
kwk
force-pushed
the
cascaded-soft-deletes
branch
from
October 25, 2018 09:11
7854b21
to
1082cdb
Compare
kwk
requested review from
jarifibrahim,
baijum,
DhritiShikhar and
michaelkleinhenz
October 25, 2018 09:23
kwk
removed request for
baijum,
aslakknutsen,
xcoulon,
sbose78,
DhritiShikhar,
michaelkleinhenz,
jarifibrahim and
tinakurian
October 25, 2018 09:28
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE: DO NOT MERGE WHEN THERE'S ONLY ONE APPROVAL.
See https://github.com/fabric8-services/fabric8-wit/blob/12f42bbe747f33bf0e3fe485d35ff66ac021d613/docs/cascading-soft-delete.md#cascading-soft-deletes for a description of what this PR does and why.
In addition to adding the cascading soft-delete mechanism for our complete database, I had to make a few adjustments to some tables:
Delete no longer needed
work_item_link_categories
categories that is no longer used since migration 106.Add missing foreign key constraint from
comments
towork_items
item and delete all comments that don't reference a work item.Change foreign key from
tracker_items
andtracker_queries
totrackers
fromON UPDATE RESTRICT ON DELETE RESTRICT
toON DELETE CASCADE
.Change foreign key from
identites
tousers
toON DELETE CASCADE
.Implements [4] When a workitem is deleted, all links associated with it are deleted of Delete workitem #2304
Addresses Work items are not deleted when space is removed openshiftio/openshift.io#4382