fix(quickAdd): dont dispatch AddSuccess action on workitem creation

fabric8-ui · Oct 23, 2018 · b2c271f · b2c271f
1 parent 18eb3bf
commit b2c271f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/src/app/components_ngrx/work-item-quick-add/work-item-quick-add.component.html b/src/app/components_ngrx/work-item-quick-add/work-item-quick-add.component.html
@@ -80,6 +80,7 @@
     type="text"
     placeholder=" Type your title...."
     #quickAddTitle
+    [formControl]="workItemTitle"
     [disabled]="blockAdd"
     [(ngModel)]="workItem.attributes['system.title']"
     (keyup.enter)="save($event)"

diff --git a/src/app/components_ngrx/work-item-quick-add/work-item-quick-add.component.ts b/src/app/components_ngrx/work-item-quick-add/work-item-quick-add.component.ts
@@ -24,6 +24,7 @@ import { PermissionQuery } from './../../models/permission.model';
 import { WorkItemQuery } from './../../models/work-item';
 
 // ngrx stuff
+import { FormControl } from '@angular/forms';
 import { select, Store } from '@ngrx/store';
 import { Observable } from 'rxjs';
 import * as WorkItemActions from './../../actions/work-item.actions';
@@ -55,6 +56,7 @@ export class WorkItemQuickAddComponent implements OnInit, OnDestroy, AfterViewIn
   linkObject: object;
   addDisabled: Observable<boolean> =
     this.permissionQuery.isAllowedToAdd();
+  workItemTitle= new FormControl('');
 
   // Board view specific
   initialDescHeight: number = 0;
@@ -197,6 +199,7 @@ export class WorkItemQuickAddComponent implements OnInit, OnDestroy, AfterViewIn
         parentId: this.parentWorkItemId,
         openDetailPage: openStatus
       }));
+      this.workItemTitle.setValue('');
     } else {
       this.blockAdd = false;
       this.error = 'Title can not be empty.';

diff --git a/src/app/components_ngrx/work-item-quick-add/work-item-quick-add.module.ts b/src/app/components_ngrx/work-item-quick-add/work-item-quick-add.module.ts
@@ -1,6 +1,6 @@
 import { CommonModule } from '@angular/common';
 import { NgModule } from '@angular/core';
-import { FormsModule } from '@angular/forms';
+import { FormsModule, ReactiveFormsModule } from '@angular/forms';
 
 import { BsDropdownConfig, BsDropdownModule } from 'ngx-bootstrap/dropdown';
 import { PermissionQuery } from '../../models/permission.model';
@@ -14,7 +14,8 @@ import { WorkItemQuickAddComponent } from './work-item-quick-add.component';
     CommonModule,
     CommonSelectorModule,
     FormsModule,
-    InfotipModule
+    InfotipModule,
+    ReactiveFormsModule
   ],
   declarations: [WorkItemQuickAddComponent],
   exports: [WorkItemQuickAddComponent],

diff --git a/src/app/effects/work-item.effects.ts b/src/app/effects/work-item.effects.ts
@@ -3,7 +3,7 @@ import { ActivatedRoute, Router } from '@angular/router';
 import { Actions, Effect } from '@ngrx/effects';
 import { select, Store } from '@ngrx/store';
 import { Notification, Notifications, NotificationType } from 'ngx-base';
-import { Observable, of } from 'rxjs';
+import { empty, Observable, of } from 'rxjs';
 import { catchError, map, mergeMap, switchMap } from 'rxjs/operators';
 import { cleanObject } from '../models/common.model';
 import { FilterService } from '../services/filter.service';
@@ -133,6 +133,7 @@ export class WorkItemEffects {
                   } catch (e) {
                     console.log('Work item is added.');
                   }
+                  return empty();
                 }
                 return of(new WorkItemActions.AddSuccess(wItem));
               }