Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

fix(auth): remove multiple instances of auth service #2819

Merged

Conversation

karthikjeeyar
Copy link
Contributor

This PR avoids creating multiple instance of authentication service (Auth service should be a singleton service)

Fixes: openshiftio/openshift.io#4639

@alien-ike
Copy link
Collaborator

alien-ike commented Dec 13, 2018

Ike Plugins (test-keeper)

Thank you @karthikjeeyar for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

@centos-ci
Copy link
Collaborator

@karthikjeeyar Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2819 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2819 and visit http://localhost:5000 to access it.

@rohitkrai03 rohitkrai03 changed the title fix(remove_duplicate_instances): remove multiple instances of auth se… fix(remove_duplicate_instances): remove multiple instances of auth service Dec 13, 2018
@rohitkrai03 rohitkrai03 changed the title fix(remove_duplicate_instances): remove multiple instances of auth service fix(auth): remove multiple instances of auth service Dec 13, 2018
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@centos-ci
Copy link
Collaborator

@karthikjeeyar Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2819 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2819 and visit http://localhost:5000 to access it.

@nimishamukherjee nimishamukherjee merged commit dea441e into fabric8-ui:master Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants