Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use productized Jolokia version #220

Open
apupier opened this issue Feb 5, 2019 · 2 comments
Open

Use productized Jolokia version #220

apupier opened this issue Feb 5, 2019 · 2 comments

Comments

@apupier
Copy link
Contributor

apupier commented Feb 5, 2019

in code it is indicated to use it when available

s2i/java/images.yml

Lines 32 to 33 in 6ba4a69

# Re-enable when productised version is available:
# jolokia: "1.5.0.redhat-1"

it is available https://maven.repository.redhat.com/ga/org/jolokia/jolokia-core/1.5.0.redhat-1/

The comment is also in community version (master branch), shouldn't stay on community jolokia and just remove the comment?

@vorburger
Copy link
Collaborator

just FTR: #221 has a PR proposing this

@vorburger
Copy link
Collaborator

The comment is also in community version (master branch), shouldn't stay on community jolokia and just remove the comment?

I would certainly merge a PR from you proposing that for the master branch ASAP... 😺

apupier added a commit to apupier/s2i that referenced this issue Feb 5, 2019


Signed-off-by: Aurélien Pupier <apupier@redhat.com>
vorburger pushed a commit that referenced this issue Feb 5, 2019
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants