Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fedora-java8 image (#160) #182

Closed
wants to merge 1 commit into from

Conversation

vorburger
Copy link
Collaborator

related to #160 Java 11 support

just because there is no Java 11 in CentOS just yet, so let's start with a Fedora based image

@vorburger vorburger requested a review from rhuss November 7, 2018 19:59
@vorburger
Copy link
Collaborator Author

vorburger commented Nov 7, 2018

@gunnarmorling (and @ctron) let's see if @rhuss would be OK to merge this ...

... the idea being, obviously, to then follow-up with a fedora-java11 next.

@rhuss
Copy link
Contributor

rhuss commented Nov 13, 2018

One question: Why do you want to have a Java 8 Fedora image to maintain when we have a CentOS one ? I understand the (temporary) need for Fedora for a Java 11 but, shouldn't it be fine to have only a Java 11 image for Fedora ?

As mentioned I relaly would like this only to have as a temporary solution, switching back to centos for Java 11 when available. The less images to maintain the better.

@vorburger
Copy link
Collaborator Author

@rhuss sure, agreed (see also #193 BTW). What happened here is simply that my dev workflow was to first see if there was any problem to create a Fedora instead of a CentOS based image, first for Java 8 (it was no problem at all), and perhaps illustrate to you / anyone else watching that this works, and that I then tackled the Java 11 image. In hind-sight I would tend to agree that we probably don't really need this Fedora based Java 8 image, and will only confuse people to have more choices... so why don't I abandon this - and rework #189 to only introduce fedora-java11 without requiring fedora-java8 - sounds like a plan?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants