Don't use image username for auto pull

If a default login for the registry is configured for authentication this will be used, regardless of the image's username. If no default login is registered, no authentication is used.

This affects only pulling. For push, the default user is extracted from the image name (but can be overwritten with options and config).

This also will fix fabric8io/fabric8-devops#46

Relates to #147

doc/changelog.md

@@ -1,5 +1,8 @@
 # ChangeLog
 
+* **0.13.6-SNAPSHOT**
+ - Don't use user from image when pulling base images (#147) 
+
 * **0.13.5**
  - Improvements for `docker:watch` ([#288](https://github.com/rhuss/docker-maven-plugin/issues/288))
  - Add parameter `kill` to `<watch>` configuration for waiting before

src/main/java/org/jolokia/docker/maven/AbstractDockerMojo.java

@@ -276,9 +276,9 @@ public void contextualize(Context context) throws ContextException {
 
  // =================================================================================
 
- protected AuthConfig prepareAuthConfig(String image, String configuredRegistry) throws MojoExecutionException {
+ protected AuthConfig prepareAuthConfig(String image, String configuredRegistry, boolean useUserFromImage) throws MojoExecutionException {
  ImageName name = new ImageName(image);
- String user = name.getUser();
+ String user = useUserFromImage ? name.getUser() : null;
  String registry = name.getRegistry() != null ? name.getRegistry() : configuredRegistry;
 
  return authConfigFactory.createAuthConfig(authConfig, settings, user, registry);
@@ -323,7 +323,7 @@ protected void checkImageWithAutoPull(DockerAccess docker, String image, String
  return;
  }
 
- docker.pullImage(withLatestIfNoTag(image), prepareAuthConfig(image, registry), registry);
+ docker.pullImage(withLatestIfNoTag(image), prepareAuthConfig(image, registry, false), registry);
  ImageName imageName = new ImageName(image);
  if (registry != null && !imageName.hasRegistry()) {
  // If coming from a registry which was not contained in the original name, add a tag from the

src/main/java/org/jolokia/docker/maven/PushMojo.java

@@ -25,7 +25,7 @@ public void executeInternal(DockerAccess docker) throws DockerAccessException, M
  String name = imageConfig.getName();
  if (buildConfig != null) {
  String configuredRegistry = getConfiguredRegistry(imageConfig);
- AuthConfig authConfig = prepareAuthConfig(name,configuredRegistry);
+ AuthConfig authConfig = prepareAuthConfig(name, configuredRegistry, true);
 
  docker.pushImage(name, authConfig, configuredRegistry);