Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use identity token from Docker config.json if present #1249

Closed
wrosenuance opened this issue Aug 7, 2019 · 1 comment · Fixed by #1250
Closed

Use identity token from Docker config.json if present #1249

wrosenuance opened this issue Aug 7, 2019 · 1 comment · Fixed by #1250

Comments

@wrosenuance
Copy link
Contributor

Description

Identity tokens in Docker config.json are not used, which prevents token-based access to Azure Container Registry.

Info

When using the Azure CLI to authenticate to Azure Container Registry, the Docker config.json is edited to add authentication information with a default username (GUID that is all zeroes) and blank password, and a time-limited access token. The default username and password are not actually acceptable: instead, the registry expects to receive the identity token, as described at https://docs.docker.com/engine/api/v1.39/#section/Authentication.

I will submit a PR to enable checking for an existing identity token as I was able to make this work fairly easily.

  • d-m-p version : 0.30.0-SNAPSHOT
  • Maven version (mvn -v) : 3.5.4
  • If it's a feature request, what is your use case :
wrosenuance added a commit to wrosenuance/docker-maven-plugin that referenced this issue Aug 7, 2019
Signed-off-by: William Rose <william.rose@nuance.com>
@rhuss
Copy link
Collaborator

rhuss commented Aug 8, 2019

Happy to integrate the PR, but please note that I will be off for 3 weeks starting next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants