Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Boolean comparison for healthy option #1279

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

fabienbancharel
Copy link
Contributor

It seems there is a regression on healthy option since 0.25.0, and the change from "boolean" to "Boolean".

It seems that "wait.getHealthy() == Boolean.TRUE" is always false, introduced in 0.25.0.
Comparison should be by value, not by reference.

Maven version : 3.5.4
JDK : 8

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #1279 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #1279   +/-   ##
=========================================
  Coverage     55.44%   55.44%           
  Complexity     1764     1764           
=========================================
  Files           156      156           
  Lines          8487     8487           
  Branches       1304     1304           
=========================================
  Hits           4706     4706           
  Misses         3327     3327           
  Partials        454      454
Impacted Files Coverage Δ Complexity Δ
...a/io/fabric8/maven/docker/service/WaitService.java 4.23% <0%> (ø) 1 <0> (ø) ⬇️

@rohanKanojia
Copy link
Member

@fabienbancharel : Thanks a lot for PR 👍 Could you please add a line to CHANGELOG regarding this change? We're good to merge this.

@fabienbancharel
Copy link
Contributor Author

fabienbancharel commented Oct 14, 2019

@rohanKanojia : Do you mean adding a line to "doc/changelog.md" ?
Thanks.

@rohanKanojia
Copy link
Member

rohanKanojia commented Oct 14, 2019 via email

@fabienbancharel
Copy link
Contributor Author

I followed this, before you answered :
"Add more commits by pushing to the master branch on xxx/docker-maven-plugin."

Do you want me to change something or is it ok ?

@rohanKanojia
Copy link
Member

👍

@rohanKanojia rohanKanojia merged commit 15f97d0 into fabric8io:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants