Support RUN Command definition, through plugin configuration

[javapapo]

I would like to be able, to define one or more 'RUN' commands, when defining my <image> element. For example, in a case where I want to execute some jboss-cli script(s), I would like to have something like

<image>
        <alias>myService</alias>
                 <name>AName</name>
                             <build>
                                    <from>jboss/wildfly</from>
                                      <maintainer>javapapo@mac.com</maintainer>
                                       <assembly>
                                           <descriptor>assembly.xml</descriptor>
                                           <basedir>/opt/jboss/wildfly/standalone/deployments</basedir>
                                        </assembly>
                                        <ports>
                                            <port>8080</port>
                                            <port>9090</port>
                                        </ports>
                                    <runCommands>
                                      <runcmd>echo "Hello World"</runcmd>
                                       <runcmd>/opt/jboss/wildfly/bin/add-user.sh admin pass --silent</runcmd>
                              </runCommands>
       </build> 
... 

and in the generated dockerFile would look like.

FROM jboss/wildfly
MAINTAINER javapapo@mac.com
EXPOSE 8080 9090
RUN echo "Hello World"
RUN /opt/jboss/wildfly/bin/add-user.sh admin pass --silent

Many thanks for considering.

[rhuss]

Good point, shouldn't be hard to add (start at DockerFileBuilder). Are you on a PR ? If not, I can implement this (after integrating some other stuff first).

[javapapo]

I will it give a try, yes I pulled master just yesterday!

[tnn]

👍 Would be great with a RUN command. Let me know if I can help.

[rhuss]

The question of course is still, where to place the RUN commands: Before or after the ADD commands ? Probably after.

[javapapo]

Hi, I have hacked an example most probably will push tomorrow, where I have the runCommands section after the ports section config. I need to see where you support ADD in the configuration.

[computerlyrik]

+1 ... need some code review on your code?

rhuss/docker-maven-plugin@master...javapapo:feature/runCmds

[computerlyrik]

Tested your code. Lacks some features from origin master.
I will try a merge tomorrow.

[computerlyrik]

Merged 👍

[javapapo]

Hello, sorry due to some work obligations I did not repost here - since I had not fully tested the change.

[javapapo]

my feature is under feature/runCmds branch

[computerlyrik]

@javapapo my pull request is about your code with a little modifications

Hopefully it gets accepted :)

[rhuss]

Thanks a lot, guys ! I will have a look at is ASAP and will integrate it ...

[javapapo]

@computerlyrik thanks great! Still think maybe we should add a bit of more checks on the parsing of the command, will wait @rhuss comments :)