Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support "docker cp" in docker:watch #268

Closed
rhuss opened this issue Aug 21, 2015 · 1 comment
Closed

Add support "docker cp" in docker:watch #268

rhuss opened this issue Aug 21, 2015 · 1 comment
Labels
feature

Comments

@rhuss
Copy link
Collaborator

rhuss commented Aug 21, 2015

docker watch currently rebuilds the whole image on change. Since Docker 1.8 docker supports the copying of files into a running container, so this will be a nice and faster alternative.

Still need to think about how to model this configuration wise.
@rhuss rhuss added the feature label Aug 21, 2015
@rhuss
Copy link
Collaborator Author

rhuss commented Sep 4, 2015

Another idea (not from me) is to use rsync via docker exec (or oc exec for openshift) to sync files into the container. This should be better perform than a plain copy.

So ideally we would support multiple variants of copying stuff into the container with an extra abstraction layer.

rhuss added a commit that referenced this issue Sep 26, 2015
@rhuss
#268: Add support for copying files into containers for docker:watch
0ae55a9 
* mode == copy added
* documentation update
* postExec config for <watch> config and globale
* Refactored log out handlng to that command exec can use the same format.
@rhuss rhuss closed this as completed Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhuss