Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter to configure the number of seconds to wait before killing the container #293

Closed
fiji-flo opened this issue Sep 18, 2015 · 1 comment

Comments

@fiji-flo
Copy link
Contributor

I would like to expose the t parameter of the stop call (see https://docs.docker.com/reference/api/docker_remote_api_v1.20/#stop-a-container) to the docker-maven-plugin configuration.

This defaults to 0 in docker. Therefore, for the process running inside there is no change of a proper shutdown, when receiving SIGTERM.

In my use case the process writes some log data, when SIGTERM is received before exiting gracefully.

With the current docker-maven-plugin this file is empty.

I extended docker-maven-plugin in a fork and it is working fine there.

@rhuss
Copy link
Collaborator

rhuss commented Sep 23, 2015

Fixed with merge of #294

@rhuss rhuss closed this as completed Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants