-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new "source" goal #311
Comments
This would be helpful. I currently use the maven-assembly-plugin to ape this functionality in my builds (which are builds of Docker images with no Java application or library):
However, this relies on a developer-level, not-enforceable-with-code convention that all source required to build the Docker image come from certain locations in the project, which both the docker-maven-plugin and maven-assembly-plugin must look at. If a developer broke this convention and only updated one of the plugins to know about it, the build would not detect this and would complete successfully, but the published Docker image would not be able to be recreated from the published .tar.gz. If the docker-maven-plugin produced this .tar.gz instead, that would guarantee that the produced Docker image would be able to be recreated from the source artifact. NamingThis is very similar in spirit to publishing the I therefore suggest |
Yeah, |
I pushed a snapshot Not right sure whether this feels right, however since multiple builds can be attached per pom.xml there must be a way to either calculate the classifier from a unique build configuration datum or needs to be specified explicitly . Maybe its better do have a dedicated build config option 'classifier' ? Either as a mandatory option for I think I go for the fallback solution since at least having the possibility to explicitly specify a classifier might make sense. Also maybe a |
mvn docker:tar
should do the same as a build but attach the docker.tar which is used for building as an artifact with classifier ('-docker' ?) to the build. This will be ideally bound to a lifecycle phase.As alternative one could think also about a new Maven top-level packaging (like
jar
orwar
), but that would required a dedicated project for the docker build.Not sure about the name, though:
docker:tar
docker:save
docker:attach
docker:install
The text was updated successfully, but these errors were encountered: