Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose extra volumes on build after runCmds #341

Closed
alethenorio opened this issue Nov 30, 2015 · 3 comments
Closed

Expose extra volumes on build after runCmds #341

alethenorio opened this issue Nov 30, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@alethenorio
Copy link

I am trying to export a few different paths in a volume container built by the plugin by setting up the assembly with all the files I need and then trying to run commands using runCmds tag to move files into folder which I expose as volumes using the tag.

This does not seem to work as I get empty directories in the folders I exposed as volumes. I believe this has to do with the fact that the copy command happens after all volumes have been exposed

It's stated clearly in the Dockerile VOLUME documentation

Note: If any build steps change the data within the volume after it has been declared, those changes will be discarded.

Wouldn't it be better to export extra volumes after all runCmds have run?

@rhuss
Copy link
Collaborator

rhuss commented Nov 30, 2015

Missed that, thanks for pointing that out. Moved it now to the end of the Dockerfile, this will be available in 0.13.7, to be released this week ...

@alethenorio
Copy link
Author

Wow, that was quick.
Awesome. I originally meant the bug report for the volumes tag but I
realise even the assembly tag created volume can probably be moved to the
end as well, keeping all volumes at the same place.

Looking forward to the release.

On Mon, 30 Nov 2015, 22:35 Roland Huß notifications@github.com wrote:

Missed that, thanks for pointing that out. Moved it now to the end of the
Dockerfile, this will be available in 0.13.7, to be released this week ...


Reply to this email directly or view it on GitHub
https://github.com/rhuss/docker-maven-plugin/issues/341#issuecomment-160768979
.

@rhuss
Copy link
Collaborator

rhuss commented Dec 1, 2015

Well, it's not always that fast ;-) (but currently I'm working on a release anyway :)

@rhuss rhuss added the fixed label Dec 1, 2015
@rhuss rhuss added this to the 0.13.7 milestone Dec 1, 2015
@rhuss rhuss self-assigned this Dec 2, 2015
@rhuss rhuss closed this as completed in 376b8cb Dec 7, 2015
leusonmario pushed a commit to leusonmario/docker-maven-plugin that referenced this issue Aug 18, 2018
do not require email to be set in settings.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants