Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: add log-driver capability to docker:run #379

Closed
rikcarve opened this issue Feb 9, 2016 · 7 comments
Closed

Enhancement: add log-driver capability to docker:run #379

rikcarve opened this issue Feb 9, 2016 · 7 comments
Labels
feature fixed
Milestone
0.14.0

Comments

@rikcarve
Copy link

rikcarve commented Feb 9, 2016

I could not find any support for using a different log-driver within docker:run.
For some containers we use the gelf log driver in docker:
sudo docker run -d --log-driver=gelf --log-opt gelf-address=udp://localhost:12201 myimage

Any plans to add this?
@jgangemi
Copy link
Collaborator

jgangemi commented Feb 9, 2016

at some point, yes. pull requests welcome...

@rikcarve
Copy link
Author

Ok, I've got it working now locally. After some cleanup I will make a pull request.

@rhuss
Copy link
Collaborator

rhuss commented Feb 11, 2016

Cool. Looking forward to the PR ;-)

@rhuss rhuss added the feature label Feb 11, 2016
@rikcarve rikcarve mentioned this issue Feb 16, 2016
Closed
@rikcarve
Copy link
Author

Finally made a pull request: #387

@rhuss
Copy link
Collaborator

rhuss commented Feb 17, 2016

Thanks ;-) 'will have a look at it ASAP

rhuss added a commit that referenced this issue Feb 24, 2016
@rhuss
#379 : Add option for specifying log driver
6f56395 
This is based on PR #387 with the following changes:

* Moved driver config to the overall LogConfiguration in the run section. Although its not directly related, having two different logging configuration sections is even more confusing.
* Adapted documentation
* Added unit tests
* Added missing log configuration properties to the PropertyHandler.
@rhuss rhuss added the fixed label Feb 24, 2016
@rhuss
Copy link
Collaborator

rhuss commented Feb 24, 2016

Merged, should be available in 0.14.0 (to be released in this week)

@rhuss rhuss added this to the 0.14.0 milestone Feb 24, 2016
@rikcarve
Copy link
Author

Thanks, tested the latest release from maven central and it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature fixed
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
3 participants
@rhuss @jgangemi @rikcarve