Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different configuration for run and build via PropertyConfigHandler #386

Closed
ppaland opened this issue Feb 15, 2016 · 2 comments
Closed

Different configuration for run and build via PropertyConfigHandler #386

ppaland opened this issue Feb 15, 2016 · 2 comments
Labels
feature

Comments

@ppaland
Copy link

ppaland commented Feb 15, 2016

The handler currently uses some properties for both build and run configuration, for example docker.env.VARIABLE. I need to set an env value for runtime (integration test) that I don't want to be in the docker container. As far as I see, this is currently not possible.

Proposal: Introduce two other sets of properties (docker.run.x and docker.build.x) to be able to configure them differently.
@rhuss
Copy link
Collaborator

rhuss commented Feb 23, 2016

You are right that's unfortunate. Its a good idea to introduce a more specific level which, when used, takes precedence over the the less specific property (without build. or run. level). That way we could also keep backwards compatibility.

I don't when having time to implement this but would happily integrate a pull request for this.

@rhuss rhuss added the feature label Feb 23, 2016
@stromnet stromnet mentioned this issue Feb 5, 2018
Closed
stromnet added a commit to stromnet/docker-maven-plugin that referenced this issue Feb 12, 2018
@stromnet
Add separate properties for build.env.build and run.env
7263026 
Addresses fabric8io#386.

Note that it was not possible to use "env.run/build", which would have
matched well with other properties, because we already have the "env"
matcher (which would have matched env.run too, injecting bad
properties).
@stromnet stromnet mentioned this issue Feb 12, 2018
Closed
stromnet added a commit to stromnet/docker-maven-plugin that referenced this issue Feb 14, 2018
@stromnet
Add separate properties for build.env.build and run.env
5492b02 
Addresses fabric8io#386.

Note that it was not possible to use "env.run/build", which would have
matched well with other properties, because we already have the "env"
matcher (which would have matched env.run too, injecting bad
properties).

Signed-off-by: Johan Ström <johan@stromnet.se>
stromnet added a commit to stromnet/docker-maven-plugin that referenced this issue Mar 18, 2018
@stromnet
Add separate properties for envRun, envBuild
7d001f7 
Addresses fabric8io#386.

Note that it was not possible to use "env.run/build", which would have
matched well with other properties, because we already have the "env"
matcher (which would have matched env.run too, injecting bad
properties).

Signed-off-by: Johan Ström <johan@stromnet.se>
@rhuss
Copy link
Collaborator

rhuss commented Mar 18, 2018

Fixed with #948

@rhuss rhuss closed this as completed Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhuss @ppaland