Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util.ImageName.doValidate not allowing legitimate, per spec, multi-component names #459

Closed
dweomer opened this issue May 25, 2016 · 1 comment
Closed

util.ImageName.doValidate not allowing legitimate, per spec, multi-component names #459

dweomer opened this issue May 25, 2016 · 1 comment

Comments

@dweomer
Copy link
Contributor

dweomer commented May 25, 2016

As per the grammar implemented/documented at http://bit.ly/docker_image_format, specifically:

name := [hostname '/'] component ['/' component]*

image names should allow multiple sub-components after the first. As implemented currently by util/ImageName.java only two total components are allowed.
dweomer added a commit to dweomer/docker-maven-plugin that referenced this issue May 26, 2016
@dweomer
allow multiple subcomponents in image names, fixing fabric8io#459
04fb590
@dweomer dweomer mentioned this issue May 26, 2016
Merged
rhuss added a commit that referenced this issue May 26, 2016
@rhuss
#459 : Adapted regex to the 'official' regexps used by docker.
6fc765e 
tbh, https://github.com/docker/docker/blob/master/vendor/src/github.com/docker/distribution/reference/regexp.go goes a bit over the top with abstrcaction. would be so cool if they used plain regexps, not that supposed to be super-intelligent abstraction.
rhuss pushed a commit that referenced this issue May 26, 2016
@dweomer @rhuss
allow multiple subcomponents in image names, fixing #459
dcd6ceb
rhuss added a commit that referenced this issue May 26, 2016
@rhuss
#459 : Adapted regex to the 'official' regexps used by docker.
18f27b3 
tbh, https://github.com/docker/docker/blob/master/vendor/src/github.com/docker/distribution/reference/regexp.go goes a bit over the top with abstrcaction. would be so cool if they used plain regexps, not that supposed to be super-intelligent abstraction.
@rhuss
Copy link
Collaborator

rhuss commented May 27, 2016

fixed in 0.15.3, just released.

@rhuss rhuss closed this as completed May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhuss @dweomer