Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-Only bind volumes are broken since 0.15.2 #462

Closed
Ironlink opened this issue May 28, 2016 · 4 comments
Closed

Read-Only bind volumes are broken since 0.15.2 #462

Ironlink opened this issue May 28, 2016 · 4 comments
Labels

Comments

@Ironlink
Copy link

Pull request #443 breaks the :ro suffix for read-only volumes.

Per the docker API documentation, the optional second colon of HostConfig.Binds separates the container path from the access mode of the mount. According to the docker user guide, Windows users are advised to use Unix-like paths such as /c/Users/path in order to avoid the colon issue.

rhuss added a commit that referenced this issue May 30, 2016
Should now work more flexibly (and still on windows when using paths in the format 'c:\...'
@rhuss
Copy link
Collaborator

rhuss commented May 30, 2016

Thanks for pointing this out. It should be fixed now. We still need to cope with pathes like c:\Users\path since thats the format as it is stored in Maven properties. However, we will do the conversion on the fly within EnvUtils.fixupPath()

@rhuss rhuss added the fixed label May 30, 2016
@deboj
Copy link

deboj commented Jun 2, 2016

when can i expect a release containing this fix?

@rhuss
Copy link
Collaborator

rhuss commented Jun 2, 2016

we will do a release tomorrow.

@rhuss
Copy link
Collaborator

rhuss commented Jun 3, 2016

0.15.4 is out :)

@rhuss rhuss closed this as completed Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants