maven goal to show logs

[jgangemi]

i feel this is a bit different then issue #8, which is why i created a new one...

how do you feel about a docker:logs command that mimics docker logs? to start, it could perform the same default behavior as docker logs <container_id> and additional features could be added later.

i'm finding myself typing mvn docker:logs after running a mvn docker:start only to realize that won't work which is rather annoying. :)

[rhuss]

Both are valid features (having the logs during a run and a dedicated dockers:logs goals for showing the logs on demand and both should of course use the same mechanism.

For the logging mentioned in #8 one would need some extra threads stream out the log as it happenns asynchronously, for docker:logs a single call to the Docker remote API for getting the current log would be enough (but of course something like tail -f would be fine, to)

Also I would like to have all logs from all containers mixed together, with lines coming from different containers higlight somehow (with color and/or prefix). This is also how fig it does.

I already have some ideas how to implement that and this will come quite soon.

[jgangemi]

oh and here i was ready to take this on...

my logs already contain ansi coloring, so you would need to take that into account (for everyone, not just me) as part of whatever you're thinking of.

[rhuss]

Coloring would be optional, so if you already have colouring one could switch that off (and colouring is switched on only when a TTY is attached). Alternatively a prefix could be configured (a coloured prefix is that what fig uses to print out the tty output).

The tricky part is to parse the chunked response and when printing to the console from multiple threads than some synchronisation is required (i.e. a dedicated thread printing out the log lines coming in from multiple containers line by line).

Also when using as a maven goal, then it should be possible to specify image via -Dimage for which to print out the logs.

I already have some prototype which I polish and add tomorrow. Sorry, I didn't want to take this off from you, but as I said I already have some very concrete ideas. But as soon as it is in, I really would like to get your opinion on this.

[jgangemi]

lol - i'm not that sad. :)

looking forward to seeing what you've come up with.

[rhuss]

;-)

[jgangemi]

commenting here b/c this is the correct place ;)

i tried this out a little today and so far so good. the one big piece of feedback do i have is if we (you) want to have some parity w/ docker, the goal should be called logs and not log.

also my first instinct is to type mvn docker:logs given all the other goal names directly match a docker command.

[rhuss]

Good catch. Will change this for the upcoming release 0.10.5

There are still some issues with ordering of log entries from multiple containers, but these will be tackled later on.