Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<wait> on container to finish #498

Closed
rhuss opened this issue Jun 28, 2016 · 2 comments
Closed

<wait> on container to finish #498

rhuss opened this issue Jun 28, 2016 · 2 comments

Comments

@rhuss
Copy link
Collaborator

rhuss commented Jun 28, 2016

A new <wait> section should be added which waits until a container is finished and exit the build according to the exit status of the container. This is useful for batch like jobs where one simply want to run a container e.g. for initializations or other task.

This could look like

<wait>
   <exit>0</exit>
</wait>

for an expected exit code of 0 (which could be the default, but since Maven doesnt allow empty tags one probably needs to provide it in any case)

@robythomas
Copy link

robythomas commented Apr 15, 2017

I have the exact requirement to run a container that would eventually exit with a proper code signifying a job completed status. Currently, I <wait> on a <log> pattern in that job container. But I've seen that somtimes this pattern matching doesn't catch it. It has happened in about two or three times already for me. While that perhaps is an issue with the <log> mechanism, having this wait for exit is exactly what I'm looking for.

@rhuss
Copy link
Collaborator Author

rhuss commented May 3, 2017

Implemented with #765

@rhuss rhuss closed this as completed May 3, 2017
rgbj pushed a commit to rgbj/docker-maven-plugin that referenced this issue Jun 21, 2017
Signed-off-by: Sebastian Lauth <github@slauth.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants