Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContainerNetworking section with Aliases for custom networks #523

Closed
wants to merge 5 commits into from

Conversation

danielwegener
Copy link
Contributor

Fixes #466

Signed-off-by: Daniel Wegener daniel@wegener.me

Implemented support for adding security options via <securityOpt> tag.
@rhuss
Copy link
Collaborator

rhuss commented Jul 28, 2016

Thanks, I will have a look at it ASAP !

@danielwegener
Copy link
Contributor Author

Um I guess I should have created the MR against integration.

@rhuss
Copy link
Collaborator

rhuss commented Jul 29, 2016

No Problem. I'm just integrating it, and found out that its nicer to have a dedicated <network> subsection like in

<network>
  <mode>custom</mode>
  <name>my-network</name>
  <alias>name1</alias>
  <alias>name2</alias>
</network>

I'm nearly finished and plan a release today. Thanks a lot for your PR, this was a very good starting point.

@rhuss
Copy link
Collaborator

rhuss commented Jul 29, 2016

BTW if a <name>...</name> is given then the default mode is custom

@danielwegener
Copy link
Contributor Author

Great to hear that! I think supporting multiple networks would still be a another step, right?

@rhuss
Copy link
Collaborator

rhuss commented Jul 29, 2016

Yes, thats another beast ;-)

@danielwegener
Copy link
Contributor Author

Cool. Going to prepare my poms for the upgrade :) I'll close this PR then.

rhuss added a commit that referenced this pull request Jul 29, 2016
@rhuss
Copy link
Collaborator

rhuss commented Jul 29, 2016

@danielwegener just pushed. I updated your sample with the new syntax.

Thanks again ... now i'm doing the release.

@rhuss
Copy link
Collaborator

rhuss commented Jul 29, 2016

0.15.13 is about to appear at maven central any time soon, heres the updated documentation --> https://fabric8io.github.io/docker-maven-plugin/#network-configuration

@danielwegener danielwegener deleted the i466 branch July 29, 2016 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants