-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ContainerNetworking section with Aliases for custom networks #523
Conversation
Implemented support for adding security options via <securityOpt> tag.
Thanks, I will have a look at it ASAP ! |
Also update the _external-configuration.adoc and added an example. Fixes fabric8io#524.
…ageConfigurations. Fixes fabric8io#466 Signed-off-by: Daniel Wegener <daniel@wegener.me>
Um I guess I should have created the MR against integration. |
No Problem. I'm just integrating it, and found out that its nicer to have a dedicated <network>
<mode>custom</mode>
<name>my-network</name>
<alias>name1</alias>
<alias>name2</alias>
</network> I'm nearly finished and plan a release today. Thanks a lot for your PR, this was a very good starting point. |
BTW if a |
Great to hear that! I think supporting multiple networks would still be a another step, right? |
Yes, thats another beast ;-) |
Cool. Going to prepare my poms for the upgrade :) I'll close this PR then. |
@danielwegener just pushed. I updated your sample with the new syntax. Thanks again ... now i'm doing the release. |
0.15.13 is about to appear at maven central any time soon, heres the updated documentation --> https://fabric8io.github.io/docker-maven-plugin/#network-configuration |
Fixes #466
Signed-off-by: Daniel Wegener daniel@wegener.me