#524 Add support for passing security options to docker #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented support for adding security options via <securityOpt> tag.
|
Thanks, will review it soon. Would you mind to add some documentations, too ? You find them in src/main/asciidoc and you can recreate the documentation with Thanks ! |
|
Sure! |
|
Thanks, looks good to me ! I changed the property to I'll do a release today, including your change. Thanks again ! |
rhuss
added a commit
that referenced
this pull request
Jul 29, 2016
Also update the _external-configuration.adoc and added an example. Fixes #524.
|
That was fast! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented support for adding security options via tag.