Adding support for Docker 1.12 HEALTHCHECK instruction

[nicolaferraro]

I can work on this

[rhuss]

awesome, go ahead ...

[nicolaferraro]

@rhuss do you think we should add something like this:

<image>
  <alias>box1</alias>
  <name>busybox</name>
  <build>
    <healthCheck>--interval=5s --timeout=3s CMD echo "good"</healthCheck>
  </build>
</image>

Or it's better the <healthCheck> to be a complex type, like:

<image>
  <alias>box1</alias>
  <name>busybox</name>
  <build>
    <healthCheck>
      <interval>5s</interval>
      <timeout>3s</timeout>
      <command>echo "good"</command>
    </healthCheck>
  </build>
</image>

I think I know the answer...

[rhuss]

LOL ;-P Didn't know that I'm so predictable :)

Of course I'd prefer the second solution, also because we could reuse Arguments for the actual healthcheck (wonder though, whether Docker supports this). Its also documented in https://dmp.fabric8.io/#misc-startup which could be reused, too.

There is another thing, which should be implemented, too. In initAndValidate the minimal Docker API version is calculated based on the features used. So, when a health check is used, then this minimal API version should be set to 1.24 (which is the API version of Docker 1.12)

[rhuss]

0.16.9 with healthceck support is out.

[danielwegener]

Hi guys. Just curious, is this healthcheck also used during docker:start to ensure a proper start order? I am thinking about migrating wait statements to HEALTHCHECKs but need too keep the dependencies are started completely semantic.