docker load support. #645
Merged
docker load support. #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katsuya Tomioka <katsuya@basistech.com>
The global option 'image' was renamed to 'filter' but the push section referenced the old name. Signed-off-by: Tamsin Slinn <tam.slinn@gmail.com>
Corrected reference to global option 'filter'
|
Thanks a lot ! I will have review next week. |
PR merged! Thanks!
PR merged! Thanks!
The message now includes the default HTTP method and the default status code range
PR merged! Thanks!
Run only on branch dmp.fabric8.io
AWS ECR key exchange closes fabric8io#637 Signed-off-by: Chas Honton <chas@apache.org>
Signed-off-by: Chas Honton <chas@apache.org>
PR merged! Thanks!
PR merged! Thanks!
rhuss
requested changes
Dec 20, 2016
There was a problem hiding this comment.
Thanks ! Looks good to me, except the place where the configuration should go (see comment).
Beside this (and beyond the scope of the PR) a docker:save goal would be nice, too, for exporting a tar archive (which then e.g. could be checked into git to be later refered to by this feature). So, if you are fancy feel, I would highly appreciate a PR for this feature, too ;-)
| @@ -33,6 +33,9 @@ | |||
| @Parameter | |||
| private String registry; | |||
|
|
|||
| @Parameter | |||
| private String file; | |||
There was a problem hiding this comment.
Actually I would move this to the <build> configuration as it is about creating images. There is should be probably called something like dockerArchive on the same footprint as dockerFile or dockerFileDir. Also there should be a check, that only one of dockerArchive and dockerFile is given.
Signed-off-by: Chas Honton <chas@apache.org>
Signed-off-by: Katsuya Tomioka <katsuya@basistech.com>
Current coverage is 48.32% (diff: 76.09%)
|
added ability to explicitly via configuration to create named volumes
via <volumes><volume> configuration.
Example config
```xml
<volumes>
<volume>
<name>Volume Name</name>
<driver>local</driver>
<driverOpts>
<driverOpt-key-name>driverOpt-value</driverOpt-key-name>
</driverOpts>
<labels>
<label-key>someValue</label-key>
<com-github-fabric8-dmp-sample-volume>
voluminous
</com-github-fabric8-dmp-sample-volume>
</labels>
</volume>
</volumes>
```
Added a new volume sample
Added a new goal volume-create
minor formatting / spelling correction for intro.md
Signed-off-by: Tom Burton <Tom.Burton@Outlook.com>
Signed-off-by: Tom Burton <Tom.Burton@Outlook.com>
fabric8io#664 (review) corrected spelling corrected ascii-doc + formatting code formatting Signed-off-by: Tom Burton <Tom.Burton@Outlook.com>
fabric8io#664 (review) corrected spelling corrected ascii-doc + formatting code formatting Signed-off-by: Tom Burton <Tom.Burton@Outlook.com>
This is a cleanup of PR fabric8io#664 with the following major points tackled: * Cleaned formatting * Removed unneeded classes and service method for listing and getting volumes. This is not needed now and probablu not in the future. * Fixed some Copy&Pase errors (like the default phase for 'volume-remove' which was the same as for 'volume-create' * Fixed tests. Please note, that *no service method* should be adapted to be "testable". Especially do not introduce a non-private method only for this purpose and test this method instead of the offiical API. Modern Mock frameworks can deal with the the problems which are tried to be solved with this. Otherwise the API gets dilulted, more complicated, more maintenance, more coupled. * Removed assert that do nothing. Tests can be still improved for the service but its fine for now, Next step is to add support for the PropertyHandler to allow configuration of the volumes also via properties.
PR merged! Thanks!
PR merged! Thanks!
Signed-off-by: Katsuya Tomioka <katsuya@basistech.com>
Signed-off-by: Katsuya Tomioka <katsuya@basistech.com>
Signed-off-by: Katsuya Tomioka <katsuya@basistech.com>
|
I moved dockerFile part to the build side. Also added a bunch of tests to pass the coverage check. Hope you don't mind. If you could review/edit the doc, that'd be great. |
PR merged! Thanks!
PR merged! Thanks!
…oka/docker-maven-plugin into Katsuya-Tomioka-docker-load-support
rhuss
approved these changes
Jan 2, 2017
| @@ -468,4 +468,9 @@ private String withLatestIfNoTag(String name) { | |||
| ImageName imageName = new ImageName(name); | |||
| return imageName.getTag() == null ? imageName.getNameWithoutTag() + ":latest" : name; | |||
| } | |||
|
|
|||
| protected void loadImage(ServiceHub hub, String image, String filename) throws DockerAccessException { | |||
There was a problem hiding this comment.
This method seems to be unused. If so, I would remove it.
| @@ -357,6 +361,19 @@ public void removeContainer(String containerId, boolean removeVolumes) | |||
| } | |||
|
|
|||
| @Override | |||
| public void loadImage(String image, String filepath) | |||
| throws DockerAccessException { | |||
| ImageName name = new ImageName(image); | |||
- docs for docker.dockerArchive external property - removed unneed boolean tag - removed unused method
|
[merge] |
rgbj
pushed a commit
to rgbj/docker-maven-plugin
that referenced
this pull request
Jun 21, 2017
- docs for docker.dockerArchive external property - removed unneed boolean tag - removed unused method
rgbj
pushed a commit
to rgbj/docker-maven-plugin
that referenced
this pull request
Jun 21, 2017
…port PR merged! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katsuya Tomioka katsuya@basistech.com