Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Upgrade to jnr-unixsocket 0.15" #672

Merged
merged 1 commit into from
Dec 23, 2016

Conversation

rhuss
Copy link
Collaborator

@rhuss rhuss commented Dec 23, 2016

@rhuss
Copy link
Collaborator Author

rhuss commented Dec 23, 2016

This reverts the upgrade to jnr-unixsocket 0.15 which seems to break d-m-p. See #660.

Unfortunately I don't have time yet to investigate this issue more, so let's go back to the old version which works quite stable most of the time.

Fixes #660.

@codecov-io
Copy link

codecov-io commented Dec 23, 2016

Current coverage is 46.66% (diff: 0.00%)

Merging #672 into master will decrease coverage by 0.76%

@@             master       #672   diff @@
==========================================
  Files           118        119     +1   
  Lines          5967       6065    +98   
  Methods           0          0          
  Messages          0          0          
  Branches       1026       1045    +19   
==========================================
  Hits           2830       2830          
- Misses         2888       2986    +98   
  Partials        249        249          
Diff Coverage File Path
0% ...cker/access/hc/unix/UnixConnectionSocketFactory.java
0% new .../fabric8/maven/docker/access/hc/unix/UnixSocket.java

Sunburst

Powered by Codecov. Last update dffb030...cee2ae0

@rhuss
Copy link
Collaborator Author

rhuss commented Dec 23, 2016

[merge]

@fusesource-ci fusesource-ci merged commit cc21086 into fabric8io:master Dec 23, 2016
@jgangemi
Copy link
Collaborator

fyi, i'm going to spend some time on this starting in january and perhaps investigate another library entirely. i keep hitting conditions where the stop for a single container hangs the build which is no bueno. 😄

@jdve
Copy link

jdve commented Feb 1, 2017

@jgangemi have you had any success? i'm also facing this hanging-on-stop problem regularly. i'd love to hear if you've had any leads/breakthroughs!

@jgangemi
Copy link
Collaborator

jgangemi commented Feb 2, 2017

unfortunately, no. jnr-unixsocket is the only thing that's even remotely maintained so it's going to be the best bet and i haven't had enough time to deep dive into the library.

a co-worker reminded me that i could get the ip address of an aws instance through the metadata service, so i've worked around the issue by opening the tcp socket and going going that route (i'm running builds inside kubernetes but still want maven to control spinning up containers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants