Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always output version in the built image name in the console about from the build goal #737

Closed
davsclaus opened this issue Mar 19, 2017 · 1 comment

Comments

@davsclaus
Copy link
Member

I am using d-m-p 0.20.0 and when I build a docker image with a hardcoded name (without version)

            <image>
              <name>camelinaction/spring-docker</name>
              <build>
                <from>openjdk:latest</from>

Then the console logs

[INFO] DOCKER> docker-build.tar: Created [camelinaction/spring-docker] in 2 seconds

It does not show the version which would be latest as there was no version specified.

I wonder if the plugin should not output this so the end-user always see the entire coordinate of the built image, eg it should log

[INFO] DOCKER> docker-build.tar: Created [camelinaction/spring-docker:latest] in 2 seconds
@rhuss
Copy link
Collaborator

rhuss commented Mar 19, 2017

Actually, if there would be provided a tag != 'latest' it would be shown here, too. Also, in the Docker world no tag always means latest and in fact, the name send to the Docker daemon is without latest in this case. If you would have specified <name>camelinaction/spring-docker:latest</name>, it would have shown the :latest here, too (it simplies puts out the name of the image).

But I agreed, let's be more specific here (although it might hinder debugging a bit as it is not the name you have configured, but shouldn't harm here)

rgbj pushed a commit to rgbj/docker-maven-plugin that referenced this issue Jun 21, 2017
This implies adding a ':latest' when no tag was given in the image configuration.

Fixes fabric8io#737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants