Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipMachine does not work #759

Closed
dpishchukhin opened this issue Apr 14, 2017 · 1 comment
Closed

skipMachine does not work #759

dpishchukhin opened this issue Apr 14, 2017 · 1 comment

Comments

@dpishchukhin
Copy link

Please fill out the following information to help us in analyzing the issue, but feel free to skip it if you don't have the information at hand or if it does not apply. Please remove everything which does not apply to the issue. Including this info paragraph ;-)

Description

true does not disable ... configuration

Info

  • d-m-p version : 0.20.1
  • Maven version (mvn -v) :
3.3.9
  • Docker version : 17.03.1-ce-mac5
  • If it's a bug, how to reproduce :
<configuration>
                            <skipMachine>true</skipMachine>
                            <machine>
                                <name>rpi-master</name>
                                <autoCreate>true</autoCreate>
                                <createOptions>
                                    <driver>virtualbox</driver>
                                    <virtualbox-cpu-count>2</virtualbox-cpu-count>
                                </createOptions>
                            </machine>

still tries to create a machine instance

DEBUG]   (f) skipMachine = true
[DEBUG]   (f) skipTag = false
[DEBUG]   (f) sourceDirectory = src/main/docker
[DEBUG]   (f) useColor = true
[DEBUG]   (f) verbose = true
[DEBUG] -- end configuration --
[WARNING] DOCKER> Host does not exist: "rpi-master"
[INFO] DOCKER> Creating docker machine "rpi-master" with args {driver=virtualbox, virtualbox-cpu-count=2}
[INFO] DOCKER> This might take a while ...
@rhuss rhuss added the bug label May 17, 2017
rhuss added a commit to rhuss/docker-maven-plugin that referenced this issue May 17, 2017
Fix skipDockerMachine when a docker machine configuration is provided.

Fixes fabric8io#759
@rhuss
Copy link
Collaborator

rhuss commented May 17, 2017

Thanks for spotting this!

@rhuss rhuss added the fixed label May 17, 2017
rgbj pushed a commit to rgbj/docker-maven-plugin that referenced this issue Jun 21, 2017
Fix skipDockerMachine when a docker machine configuration is provided.

Fixes fabric8io#759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants