-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postStart exec breakOnError only fails when all containers have started #970
Comments
I agree with you that the plugin should 'fail fast'. Shouldn't be hard to fix hopefully. I hope to jump on to this asap, but you could accelerate this by submitting a PR ;-) |
jpraet
added a commit
to kszbcss/docker-maven-plugin
that referenced
this issue
Mar 18, 2018
Signed-off-by: Jimmy Praet <jimmy.praet@ksz-bcss.fgov.be>
jpraet
added a commit
to kszbcss/docker-maven-plugin
that referenced
this issue
Mar 18, 2018
Signed-off-by: Jimmy Praet <jimmy.praet@ksz-bcss.fgov.be>
jpraet
added a commit
to kszbcss/docker-maven-plugin
that referenced
this issue
Mar 18, 2018
Signed-off-by: Jimmy Praet <jimmy.praet@ksz-bcss.fgov.be>
jpraet
added a commit
to kszbcss/docker-maven-plugin
that referenced
this issue
Mar 26, 2018
Signed-off-by: Jimmy Praet <jimmy.praet@ksz-bcss.fgov.be>
jpraet
added a commit
to kszbcss/docker-maven-plugin
that referenced
this issue
Mar 26, 2018
Signed-off-by: Jimmy Praet <jimmy.praet@ksz-bcss.fgov.be>
rhuss
added a commit
that referenced
this issue
Apr 3, 2018
#970 postStart exec breakOnError should fail fast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a build with multiple docker images, and have configured startParallel = false, so the containers start sequentially.
The first container (db2express) is configured with a postExec wait action, with breakOnError=true.
I notice because of delay in the logs that the postExec script of the first container is executed before the second container is started. This is as expected. However, when the postExec script fails, I would expect the build to fail immediately. Instead, it first starts the remaining containers, and only once they are all started am I seeing the error from the postExec script.
This is docker-maven-plugin 0.24.0 and docker 0.12.6 on Windows 7.
The text was updated successfully, but these errors were encountered: