Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create volumes with proper configuration during "docker:start" #986

Closed
rhuss opened this issue Apr 6, 2018 · 0 comments
Closed

Create volumes with proper configuration during "docker:start" #986

rhuss opened this issue Apr 6, 2018 · 0 comments
Assignees
Labels

Comments

@rhuss
Copy link
Collaborator

rhuss commented Apr 6, 2018

If a volume is refered to during startup in a bind mount mapping and if this does not exist and a volume configuration exists, then this should be taken to create the volume upfront, not relying on Docker to create it implicitly during startup with default params.

This would avoid the necessity to call volume-create explicitly before start when a custom volume configuration is used.

See #985 for a concrete use case.

The documentation needs also an update to reflect that you cannot only configure real host paths in bind mounts, but also volumes (this is also weak in the Docker documentation itself).

@rhuss rhuss added the feature label Apr 6, 2018
@rohanKanojia rohanKanojia self-assigned this Apr 22, 2018
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Apr 22, 2018
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue May 16, 2018
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue May 16, 2018
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Jul 6, 2018
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Jul 6, 2018
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Jul 30, 2018
@rhuss rhuss closed this as completed in c1c7d35 Sep 25, 2018
rhuss added a commit that referenced this issue Sep 25, 2018
Fix #986 : Create volumes with proper configuration during "docker:start"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants