Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jnr-unixsocket version to 0.21 #1089

Merged
merged 7 commits into from
Dec 12, 2018
Merged

Conversation

pvaduva
Copy link
Contributor

@pvaduva pvaduva commented Sep 26, 2018

jnr-unixsocket version 0.20 added arm64 support
si in otder to have the plugin working on arm64
we will need that version

jnr-unixsocket version 0.20 added arm64 support
si in otder to have the plugin working on arm64
we will need that version
@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #1089 into master will decrease coverage by 0.24%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1089      +/-   ##
============================================
- Coverage     51.97%   51.73%   -0.25%     
+ Complexity     1457     1441      -16     
============================================
  Files           150      150              
  Lines          7821     7788      -33     
  Branches       1165     1158       -7     
============================================
- Hits           4065     4029      -36     
- Misses         3361     3363       +2     
- Partials        395      396       +1
Impacted Files Coverage Δ Complexity Δ
...abric8/maven/docker/access/hc/unix/UnixSocket.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...g/handler/compose/DockerComposeServiceWrapper.java 58.76% <0%> (-2.82%) 55% <0%> (-7%)
...n/java/io/fabric8/maven/docker/util/ImageName.java 91.35% <0%> (-1.15%) 35% <0%> (ø)
...ig/handler/compose/DockerComposeConfigHandler.java 71.73% <0%> (-0.9%) 17% <0%> (ø)
...va/io/fabric8/maven/docker/service/RunService.java 51.07% <0%> (-0.64%) 25% <0%> (ø)
...ic8/maven/docker/config/RunImageConfiguration.java 90.27% <0%> (-0.58%) 46% <0%> (-3%)
...bric8/maven/docker/access/ContainerHostConfig.java 84.53% <0%> (-0.47%) 36% <0%> (-3%)
...config/handler/property/PropertyConfigHandler.java 73.87% <0%> (-0.35%) 112% <0%> (-3%)
...aven/docker/config/handler/property/ConfigKey.java 100% <0%> (ø) 10% <0%> (ø) ⬇️
...o/fabric8/maven/docker/model/ContainerDetails.java 65.82% <0%> (ø) 20% <0%> (ø) ⬇️
... and 4 more

@rhuss
Copy link
Collaborator

rhuss commented Sep 28, 2018

@pvaduva Thanks for the PR ! I have to check it because the last time I tried to update to 0.19 it was a mess breaking all sort of things.

But if it works ok for and maybe also some other issues we had with the jnr-unixsocket which mixed up parallel connections, then we will merge it for sure.

I hope I can do some experiments over the weekend.

@pvaduva
Copy link
Contributor Author

pvaduva commented Oct 5, 2018

@pvaduva Thanks for the PR ! I have to check it because the last time I tried to update to 0.19 it was a mess breaking all sort of things.

But if it works ok for and maybe also some other issues we had with the jnr-unixsocket which mixed up parallel connections, then we will merge it for sure.

I hope I can do some experiments over the weekend.

Thanks for looking to it, Please tell me if there's anything I can do to help.
If it does not work with the new version is there any way we can integrate
arm64 support ? (Adding them to a fork from jnr-unixsocket 0.12 for example)

Best Regards.

@pvaduva
Copy link
Contributor Author

pvaduva commented Oct 24, 2018 via email

@gbloisi
Copy link

gbloisi commented Dec 4, 2018

In the meanwhile a 0.21 version has been released, just come to this because I'm facing issue #552 too.

Paul Vaduva added 2 commits December 7, 2018 12:23
@pvaduva pvaduva changed the title Upgrade jnr-unixsocket version to 0.20 Upgrade jnr-unixsocket version to 0.21 Dec 10, 2018
@rhuss
Copy link
Collaborator

rhuss commented Dec 12, 2018

Ok, lets try it. I did some brief sanity checks and it looks good so far. Hopefully the issues we had the Unix socker are resolved.

I'm planning a release later this week.

@rhuss rhuss merged commit 0d8bc9c into fabric8io:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants