Fix #541: Allow @sha256 digest for tags in FROM #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1131 +/- ##
============================================
+ Coverage 52.23% 52.29% +0.06%
- Complexity 1468 1472 +4
============================================
Files 150 150
Lines 7840 7852 +12
Branches 1166 1168 +2
============================================
+ Hits 4095 4106 +11
Misses 3347 3347
- Partials 398 399 +1
|
rhuss
requested changes
Dec 12, 2018
| if(fullName.contains("@sha256")) { // Of it contains digest | ||
| String[] digestParts = fullName.split("@"); | ||
| digest = digestParts[1]; | ||
| repository = digestParts[0]; |
There was a problem hiding this comment.
What if the user specified a registry/respository@sha245:digest ? What happens with the registry ?
| @@ -125,6 +125,8 @@ public void testRegistryNamingExtended() throws Exception { | |||
| new ImageName("docker.jolokia.org/org/jolokia/jolokia_demo").getFullName("another.registry.org")); | |||
| assertEquals("docker.jolokia.org/org/jolokia/jolokia_demo:latest", | |||
| new ImageName("docker.jolokia.org/org/jolokia/jolokia_demo").getFullName(null)); | |||
| assertEquals("docker.jolokia.org/org/jolokia/jolokia_demo@sha256:2781907cc3ae9bb732076f14392128d4b84ff3ebb66379d268e563b10fbfb9da", | |||
| new ImageName("docker.jolokia.org/org/jolokia/jolokia_demo@sha256:2781907cc3ae9bb732076f14392128d4b84ff3ebb66379d268e563b10fbfb9da").getFullName(null)); | |||
There was a problem hiding this comment.
Could add a check here that ImageName.getRegistry() returns indeed docker.jolokia.org ? (i doubt that)
rohanKanojia
force-pushed
the
issue541
branch
from
30a3a36
to
0c8682a
Compare
rhuss
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #541