Issue #1203 NPE if docker:save called with filename only. #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
=========================================
Coverage 53.08% 53.08%
Complexity 1532 1532
=========================================
Files 150 150
Lines 7985 7985
Branches 1202 1202
=========================================
Hits 4239 4239
Misses 3328 3328
Partials 418 418
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
=========================================
Coverage 53.08% 53.08%
Complexity 1532 1532
=========================================
Files 150 150
Lines 7985 7985
Branches 1202 1202
=========================================
Hits 4239 4239
Misses 3328 3328
Partials 418 418
|
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
=========================================
Coverage 53.08% 53.08%
Complexity 1532 1532
=========================================
Files 150 150
Lines 7985 7985
Branches 1202 1202
=========================================
Hits 4239 4239
Misses 3328 3328
Partials 418 418
|
Signed-off-by: William Rose <william.rose@nuance.com>
rhuss
reviewed
Apr 12, 2019
| @@ -106,7 +106,7 @@ private String completeCalculatedFileName(String file) throws MojoExecutionExcep | |||
| } | |||
|
|
|||
| private void ensureSaveDir(String fileName) throws MojoExecutionException { | |||
| File saveDir = new File(fileName).getParentFile(); | |||
| File saveDir = new File(fileName).getAbsoluteFile().getParentFile(); | |||
There was a problem hiding this comment.
thanks ! @rohanKanojia : FYI, this fix very likely fixes also #1200 if applied to getContextDir()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NPE that happens if you run mvn docker:save -Dfile=no-directory-name.tar
Signed-off-by: William Rose william.rose@nuance.com