Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1205 Increase GZIP compression speed for docker:save. #1206

Merged
merged 3 commits into from
Apr 12, 2019

Conversation

wrosenuance
Copy link
Contributor

Change the default compression level to 3 in line with JDK-8142920 and increase buffer sizes for copy and compression.

Signed-off-by: William Rose william.rose@nuance.com

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #1206 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1206      +/-   ##
============================================
- Coverage     53.08%   53.05%   -0.04%     
  Complexity     1532     1532              
============================================
  Files           150      150              
  Lines          7985     7990       +5     
  Branches       1202     1202              
============================================
  Hits           4239     4239              
- Misses         3328     3333       +5     
  Partials        418      418
Impacted Files Coverage Δ Complexity Δ
...ven/docker/access/hc/DockerAccessWithHcClient.java 14.23% <0%> (ø) 13 <0> (ø) ⬇️
...rc/main/java/io/fabric8/maven/docker/SaveMojo.java 24.24% <0%> (-0.76%) 12 <0> (ø)
...abric8/maven/docker/config/ArchiveCompression.java 61.9% <0%> (-10.32%) 8 <0> (ø)

1 similar comment
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #1206 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1206      +/-   ##
============================================
- Coverage     53.08%   53.05%   -0.04%     
  Complexity     1532     1532              
============================================
  Files           150      150              
  Lines          7985     7990       +5     
  Branches       1202     1202              
============================================
  Hits           4239     4239              
- Misses         3328     3333       +5     
  Partials        418      418
Impacted Files Coverage Δ Complexity Δ
...ven/docker/access/hc/DockerAccessWithHcClient.java 14.23% <0%> (ø) 13 <0> (ø) ⬇️
...rc/main/java/io/fabric8/maven/docker/SaveMojo.java 24.24% <0%> (-0.76%) 12 <0> (ø)
...abric8/maven/docker/config/ArchiveCompression.java 61.9% <0%> (-10.32%) 8 <0> (ø)

Signed-off-by: William Rose <william.rose@nuance.com>
Signed-off-by: William Rose <william.rose@nuance.com>
Copy link
Collaborator

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! I agree that build time matters, and that the increased image size (~ 10% if I understood correctly) it tolerable.

@rhuss rhuss merged commit adc22e7 into fabric8io:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants