Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1112: portPropertyFile not written anymore #1248

Merged
merged 2 commits into from
Jul 28, 2019

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jul 27, 2019

Fix #1112

port mappings should be written after we start containers.

Tested on https://github.com/r0haaaan/dmp-demo-project project with and without this patch. With this patch, I was able to see ports.properties file getting generated:

~/work/repos/dmp-demo-project : $ mvn docker:start
[INFO] Scanning for projects...
[INFO] 
[INFO] -----------------------< io.fabric8:dockerfile >------------------------
[INFO] Building dmp-sample-dockerfile 0.30-SNAPSHOT
[INFO] --------------------------------[ war ]---------------------------------
[INFO] 
[INFO] --- docker-maven-plugin:0.30-SNAPSHOT:start (default-cli) @ dockerfile ---
[INFO] DOCKER> [test-db:latest] "dockerfile": Start container 32772f1b0130
[INFO] DOCKER> [test-db:latest] "dockerfile": Pausing for 5000 ms
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  6.936 s
[INFO] Finished at: 2019-07-27T21:53:29+05:30
[INFO] ------------------------------------------------------------------------
~/work/repos/dmp-demo-project : $ cat src/main/resources/ports.properties 
#Docker ports
#Sat Jul 27 21:53:29 IST 2019
host.port=32787
~/work/repos/dmp-demo-project : $ 

rohanKanojia and others added 2 commits July 27, 2019 21:50
port mappings should be written after we start containers.
@rhuss
Copy link
Collaborator

rhuss commented Jul 28, 2019

Thanks !

@rhuss rhuss merged commit cb9930e into fabric8io:master Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.27.2] portPropertyFile not written anymore
2 participants