Prefer HOME environment variable

[twz123]

The Java system property is filled by a syscall to determine the user's home directory. This is not matching the typical implementation of the docker and kubectl binaries, which prefer the HOME OS environment variable over the syscall.

[rhuss]

Which is actually your use case in which both values are different ?

[rhuss]

.

[twz123]

I discovered this during the execution of a CI build, where the HOME variable was changed inside the build and the login to the Docker registry was made by docker login. The dmp wasn't picking up the login credentials in that case. My workaround was to also define JAVA_TOOL_OPTIONS="-Duser.home=.... Took me quite a while to figure out the problem. That's why I thought it might be a good idea to actually file a PR here.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

100.0% Coverage
0.0% Duplication

[codecov]

Codecov Report

Merging #1263 (b77caf1) into master (fafa324) will increase coverage by 0.02%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##             master    #1263      +/-   ##
============================================
+ Coverage     61.99%   62.02%   +0.02%     
- Complexity     2148     2150       +2     
============================================
  Files           166      166              
  Lines          9470     9472       +2     
  Branches       1438     1438              
============================================
+ Hits           5871     5875       +4     
+ Misses         3084     3083       -1     
+ Partials        515      514       -1     

Impacted Files	Coverage Δ	Complexity Δ
.../maven/docker/access/DockerConnectionDetector.java	62.00% <0.00%> (ø)	5.00 <0.00> (ø)
...a/io/fabric8/maven/docker/util/DockerFileUtil.java	82.30% <100.00%> (+1.26%)	37.00 <1.00> (ø)
...ain/java/io/fabric8/maven/docker/util/EnvUtil.java	79.41% <100.00%> (+0.51%)	67.00 <3.00> (+2.00)
...o/fabric8/maven/docker/util/VolumeBindingUtil.java	82.35% <100.00%> (ø)	23.00 <0.00> (ø)

[twz123]

Updated the changelog.

[rhuss]

I think this PR is valid, as a user can change HOME but not user.home.

I wonder whether we need update/add some documentation, too ?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

100.0% Coverage
0.0% Duplication

[rhuss]

user.home is not only used inDockerFileUtil but also in e.g VolumeBindUtil and also in DockerConnectionDetector. While I'm positive to this change I think we should also update all other places where user.home is used as the location of the home directory.

@twz123 anything you would like to tackle, too ? (sorry for the long delay, the intervals when i'm able to work on dmp get longer and longer ...)

[twz123]

,@rhuss sure, I'll have a look, although this might take some time on my side, too 🙈

[rhuss]

,@rhuss sure, I'll have a look, although this might take some time on my side, too 🙈

thanks ! and no worries, we are operating on a slow time scale anyway (sorry, i feel guilty a bit here that everything is so slow here, but i'm working on a solution here)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

100.0% Coverage
0.0% Duplication

[rohanKanojia]

@twz123 : polite ping, Are you still working on this?

[rhuss]

@rohanKanojia let's fix that on our own, fix shouldn't be hard. @twz123 hope this is ok for you when we take over the last steps.