Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue 1354 - Verify that REPO_TAGS can be processed as a JsonArray #1355

Merged
merged 3 commits into from
Aug 30, 2020

Conversation

robinr618
Copy link
Contributor

REPO_TAGS member may be null (JsonNull), so we need to make sure it is an instance of JsonArray

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #1355 into master will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1355      +/-   ##
============================================
- Coverage     56.48%   56.32%   -0.16%     
+ Complexity     1835     1820      -15     
============================================
  Files           158      158              
  Lines          8721     8680      -41     
  Branches       1340     1331       -9     
============================================
- Hits           4926     4889      -37     
- Misses         3322     3323       +1     
+ Partials        473      468       -5     
Impacted Files Coverage Δ Complexity Δ
...va/io/fabric8/maven/docker/model/ImageDetails.java 70.96% <100.00%> (+3.22%) 13.00 <0.00> (+2.00)
...ric8/maven/docker/util/CredentialHelperClient.java 44.44% <0.00%> (-8.75%) 4.00% <0.00%> (-2.00%)
...ava/io/fabric8/maven/docker/access/AuthConfig.java 92.00% <0.00%> (-4.00%) 15.00% <0.00%> (-1.00%)
...a/io/fabric8/maven/docker/util/DockerFileUtil.java 77.14% <0.00%> (-2.30%) 20.00% <0.00%> (-14.00%)
...maven/docker/util/aws/AwsSdkAuthConfigFactory.java 60.00% <0.00%> (+4.44%) 4.00% <0.00%> (ø%)

@robinr618 robinr618 changed the title Verify that REPO_TAGS can be processed as a JsonArray Fix for Issue 1354 - Verify that REPO_TAGS can be processed as a JsonArray Jun 24, 2020
REPO_TAGS member may be null (JsonNull), so we need to make sure it is an instance of JsonArray

Signed-off-by: Robin Raju <robinr618@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rhuss
Copy link
Collaborator

rhuss commented Aug 30, 2020

Thanks ! looks good to me

@rhuss rhuss merged commit b94598f into fabric8io:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants