Add skipPush option to build image configuration (#1243)

[mattnelson]

Add skipPush option to build image configuration from #1243

Was getting test failures locally with AuthConfigFactoryTest due to my ~/.kube/config setup, wasn't sure what needed to be done to get those to pass.

Example of the output from my build which consumed these proposed plugin changes.

[INFO] --- docker-maven-plugin:0.33-SNAPSHOT:push (push-image) @ my-module ---
[INFO] DOCKER> [my-registry/my-image:image1] : Skipped pushing
[INFO] DOCKER> Credentials helper reply for "docker-credential-desktop" is 0.6.0
[INFO] DOCKER> The push refers to repository [my-registry/my-image]
[INFO] DOCKER> image2: digest: sha256:abcd size: 1234
[INFO] DOCKER> Temporary image tag skipped. Target image 'my-registry/my-image:image2' already has registry set or no registry is available
[INFO] DOCKER> Pushed my-registry/my-image:image2 in 18 seconds

[codecov]

Codecov Report

Merging #1368 into master will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1368      +/-   ##
============================================
+ Coverage     56.83%   57.13%   +0.29%     
- Complexity     1842     1844       +2     
============================================
  Files           159      159              
  Lines          8730     8723       -7     
  Branches       1337     1336       -1     
============================================
+ Hits           4962     4984      +22     
+ Misses         3299     3270      -29     
  Partials        469      469              

Impacted Files	Coverage Δ	Complexity Δ
...8/maven/docker/config/BuildImageConfiguration.java	80.56% <100.00%> (+1.22%)	80.00 <3.00> (+1.00)
...aven/docker/config/handler/property/ConfigKey.java	100.00% <100.00%> (ø)	10.00 <0.00> (ø)
...config/handler/property/PropertyConfigHandler.java	76.47% <100.00%> (ø)	123.00 <0.00> (ø)
.../fabric8/maven/docker/service/RegistryService.java	82.05% <100.00%> (+18.05%)	14.00 <0.00> (+3.00)
.../io/fabric8/maven/docker/service/BuildService.java	50.69% <0.00%> (-0.44%)	25.00% <0.00%> (-1.00%)
...a/io/fabric8/maven/docker/access/BuildOptions.java	96.15% <0.00%> (-0.28%)	19.00% <0.00%> (-2.00%)
...abric8/maven/docker/config/ImageConfiguration.java	60.75% <0.00%> (+2.53%)	20.00% <0.00%> (ø%)
... and 2 more

[rhuss]

Looks good, but I would add a test for pushImages, too in RegistryServiceTest if possible.

If you dont have time for that, we can merge this PR nevertheless

Thanks a lot for your contribution !

[rhuss]

I know there is a test missing in RegistryServiceTest for pushImages, but it would be cool if you could add one to test this change, too (then the Sonar check would be happy, too). It shouldn't be hard to add, as it should work the same as the pull test, too.

[rhuss]

Ah, and could you please also add an enty to the changelog.md ? thanks !

[mattnelson]

Looks good, but I would add a test for pushImages, too in RegistryServiceTest if possible.

Ah, and could you please also add an enty to the changelog.md ? thanks !

both done in 2dba1fb

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
3 Code Smells

100.0% Coverage
0.0% Duplication

[rhuss]

Cool, thanks a ton !