Chunked response errors should fail plugin execution #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public interface ChunkedResponseHandler<T> { | ||
| void process(T toProcess); | ||
| void process(T toProcess) throws DockerAccessException; |
There was a problem hiding this comment.
Updating the interface contract to allow for exception throwing. DockerAccessException may not be the best choice based on its description, but everything seemed to funnel into it anyway, so I went with that instead of creating a whole new class of exception.
|
Looks good to me. Yes, currently there's only The fix is applied for 0.11.4 which will be released quite soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to fix this issue: https://github.com/rhuss/docker-maven-plugin/issues/167
I saw that there was already some processing around chunked responses to parse them and log their messages. This just takes it one small step further and throws an exception if the chucked response contains an error (effectively causing the plugin execution to fail).