-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#181: Fix bug when authenticating to private registry #220
#181: Fix bug when authenticating to private registry #220
Conversation
Signed-off-by: Christian Fischer <sw-dev@computerlyrik.de>
- introduced 'BuildService' - cleaned up plexus components - use mockito for testing Signed-off-by: Jae Gangemi <jgangemi@gmail.com>
- url builder refactoring Signed-off-by: Jae Gangemi <jgangemi@gmail.com>
Thanks ! 'will review this PR ASAP. |
- fixed model classes to only return first 12 of container id - doc update / re-arrange sub-elements into alphabetical order Signed-off-by: Jae Gangemi <jgangemi@gmail.com>
Cleaned up quite a bit, removed classes and made things more consistent. I.e. UrlBuilder is now homogenous. Removed also argument classes, since as long as we have so small argument list they only add to complexity (instead of clarifying things). Fixes fabric8io#230.
…maven-plugin into 229-skip-containers
Relates to fabric8io#229 and fabric8io#207.
…ons. The http client was not correctly used which was leaving connections open and not being able to reuse, which caused at some point to reach the max connections per route. We faced this particular issue when trying to build 2 images with 2 tags each: since the default limit of connections per route host is 2 when we tried to build the images the plugin was getting stuck trying to get more connections. The change consists mainly in changing execute with returns of result with proper ResponseHandlers so http client library automatically handles response automatic close to release open connections. Signed-off-by: Roger Abelenda <rabelenda@gmail.com>
Could you please sign-off the the PR as described in here ? Thanks a lot ! |
e01f0f9
to
bcced1e
Compare
…ess" to authentication header. Signed-off-by: Jorge Davison <jdavisonc@gmail.com>
bcced1e
to
c28007f
Compare
Done! If you require any further information, let me know. |
Thanks ;-) I just tried out the patch and it prevented me to push to Does pushing to |
I only test the pull/push against a private repository V1, not the docker.io ones. Maybe is a error with that version only. |
Did you have a chance to check it with the official repository ? I wil postpone this PR for a later release since I'm going to cut 0.13.3 today. |
Is authentication still an issue for you ? Sorry for the long delay. It seems thaat Authentication will be generally be polished via #147. |
I still using V1, but anyway I resolve the problem with other solution. Thanks anyway, I'll close this PR. |
#181
Fix bug when authenticating to private registry, add "serveraddress" to authentication header.
Base on the following documentation, "serveraddress" is required by Docker for authenticate. Not adding this part on header generates "Authentication required." error.