-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docker machine support #481
Conversation
Thanks again ;) Just about to integrate it into the code base (already rebased it), but I have still some questions, though |
@@ -67,9 +68,13 @@ | |||
protected Settings settings; | |||
|
|||
// Current maven project | |||
@Parameter(defaultValue= "${session}", readonly = true) | |||
@Parameter(property= "session") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change important ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an important change. Aligned with latest recommended practice.
Chas
On Jun 26, 2016, at 6:29 PM, Roland Huß notifications@github.com wrote:
In src/main/java/io/fabric8/maven/docker/AbstractDockerMojo.java:
@@ -67,9 +68,13 @@
protected Settings settings;// Current maven project
- @parameter(defaultValue= "${session}", readonly = true)
- @parameter(property= "session")
Why is this change important ?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, looks cleaner. will probably align the other usages, too.
I'm nearly finished with including your patch and push it soon to branch integration. There will probably be a release today. 'hope my changes are ok for you (tuned a bit documentation, logging, class names ...) |
Any change ok by me. Thanks for your dedication in supporting this plugin. Chas
|
I thank you for the contribution, its really awesome to have docker machine support now, which makes automation even easier. ;-) |
As it is now in integration I'm closing this PR. For unit tests please open a new one. thanks ... |
This pull request replaces #437.
Add a configuration section <machine> which configures use of docker-machine. The precedence order of configuration is
unix:///var/run/docker.sock
/~/.docker/
)<machine> has three sub-elements:
To use the <machine> element, docker-machine must be installed on the build host.
Before querying docker-machine for daemon values, the docker-machine will be started if necessary.