- add support for pulling an image once per (reactor) build #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, will have look soon. |
jgangemi
force-pushed
the
jae/auto-pull-once
branch
2 times, most recently
from
6c50392 to
b41154e
Compare
Signed-off-by: Jae Gangemi <jgangemi@gmail.com>
jgangemi
force-pushed
the
jae/auto-pull-once
branch
from
b41154e to
136bc01
Compare
|
any updates on this? |
|
Uff, everyone is on PTO except for me. Tons of stuff todo, but yeah, you are right, this should be a bit upper in the queue ;-) will try to do it this evening. If not, please keep nagging me ;-) |
|
cool - i'm going to try and get the push retry finished off today (i just need to do the tests) as well. |
|
|
||
| - Allow images to only be pulled once per build (useful for reactor projects) ([#504](https://github.com/fabric8io/docker-maven-plugin/issues/504)) | ||
|
|
||
| >>>>>>> Stashed changes |
|
Thanks a lot, LGTM. If you don't mind (and agree to my nit-picking ;-) I'd fix the minor gotchas myself, in order to speed things up. |
|
And yes, thanks to get into jmockit. Not easy in the beginning, I know, but quite powerful (especially when it comes to partial mocks). Also kudos for providing unit tests and docs from the very beginning. Not the usual case. |
rhuss
added a commit
that referenced
this pull request
Jul 19, 2016
rhuss
added a commit
that referenced
this pull request
Jul 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #504 and allows images to be auto-pulled once for an entire build.