Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of warnings are displayed when assembly.mode is tar or tgz when building on windows #593

Merged
merged 2 commits into from
Oct 28, 2016

Conversation

zoltanersek
Copy link

Addressing issue #591

…building on windows

Signed-off-by: Zoltan Ersek <zoltan.ersek@hpe.com>
@rhuss
Copy link
Collaborator

rhuss commented Oct 19, 2016

Thanks a lot. I'm currently on the road but will be back soon. Will check out the PR ASAP.

@rhuss
Copy link
Collaborator

rhuss commented Oct 22, 2016

Thanks a lot, makes sense to add this option.

Could you please do me the following favours:

Thanks !

Signed-off-by: Zoltan Ersek <zoltan.ersek@hpe.com>
@zoltanersek
Copy link
Author

Thanks. I've signed the commit and added the documentation.

@rhuss
Copy link
Collaborator

rhuss commented Oct 24, 2016

Thanks a lot, will include the PR in the next release (probably end of the week)

rhuss added a commit that referenced this pull request Oct 26, 2016
Signed-off-by: Roland Huß <roland@ro14nd.de>
@rhuss rhuss added the applied label Oct 26, 2016
@rhuss rhuss merged commit c6c2ecb into fabric8io:master Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants