Add new assembly option "name" #771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this can be used to specify the assembly name which is used also as directory for holding the assembly files. I.e. the directory which needs to be refered to when an extrean Dockerfile wants to include an assembly. "targetDir" now defaults to "/" + this name. Also extended the documentation to clarify the usage. Fixes fabric8io#634
|
SonarQube analysis reported 2 issues
Watch the comments in this conversation to review them. 1 extra issueNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
ghost
reviewed
May 3, 2017
| @@ -132,7 +131,7 @@ public TarArchiver customize(TarArchiver archiver) throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| return createBuildTarBall(buildDirs, customizer, assemblyMode, buildConfig.getCompression()); | |||
| return createBuildTarBall(assemblyConfig.getName(), buildDirs, customizer, assemblyMode, buildConfig.getCompression()); | |||
There was a problem hiding this comment.
NullPointerException might be thrown as 'assemblyConfig' is nullable here 
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
============================================
+ Coverage 47.68% 47.69% +0.01%
Complexity 1043 1043
============================================
Files 131 131
Lines 6751 6755 +4
Branches 879 879
============================================
+ Hits 3219 3222 +3
Misses 3258 3258
- Partials 274 275 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this can be used to specify the assembly name which is used also as directory
for holding the assembly files. I.e. the directory which needs to be refered to when
an extrean Dockerfile wants to include an assembly. "targetDir" now defaults to "/" + this name.
Also extended the documentation to clarify the usage.
Fixes #634