Add new assembly option "name" #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this can be used to specify the assembly name which is used also as directory for holding the assembly files. I.e. the directory which needs to be refered to when an extrean Dockerfile wants to include an assembly. "targetDir" now defaults to "/" + this name. Also extended the documentation to clarify the usage. Fixes fabric8io#634
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
============================================
+ Coverage 47.43% 47.46% +0.03%
- Complexity 1053 1054 +1
============================================
Files 134 134
Lines 6831 6835 +4
Branches 888 888
============================================
+ Hits 3240 3244 +4
Misses 3316 3316
Partials 275 275
|
|
[merge] |
rgbj
pushed a commit
to rgbj/docker-maven-plugin
that referenced
this pull request
Jun 21, 2017
PR merged! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this can be used to specify the assembly name which is used also as directory
for holding the assembly files. I.e. the directory which needs to be refered to when
an extrean Dockerfile wants to include an assembly. "targetDir" now defaults to "/" + this name.
Also extended the documentation to clarify the usage.
Fixes #634