#917 additional verbose-level logging on docker PUT/POST/DELETE

[kennymacleod]

As described in #917 it'd be most excellent to perform verbose-level logging when we issue commands to the docker daemon. This is extremely useful when reconciling the maven plugin configuration against what the plugin is actually issuing to docker.

Currently, the verbose=true option isn't used for much of anything other than logging image build commands.

[codecov]

Codecov Report

Merging #918 into master will decrease coverage by 2.03%.
The diff coverage is 9.09%.

@@             Coverage Diff              @@
##             master     #918      +/-   ##
============================================
- Coverage     53.78%   51.74%   -2.04%     
+ Complexity     1617     1221     -396     
============================================
  Files           154      141      -13     
  Lines          8174     7172    -1002     
  Branches       1251      960     -291     
============================================
- Hits           4396     3711     -685     
+ Misses         3342     3145     -197     
+ Partials        436      316     -120

Impacted Files	Coverage Δ	Complexity Δ
...ven/docker/access/hc/DockerAccessWithHcClient.java	13.86% <9.09%> (-0.38%)	12 <0> (-1)
...abric8/maven/docker/service/ServiceHubFactory.java	0% <0%> (-80%)	0% <0%> (-2%)
...rc/main/java/io/fabric8/maven/docker/SaveMojo.java	0% <0%> (-77.03%)	0% <0%> (-34%)
...va/io/fabric8/maven/docker/service/ServiceHub.java	0% <0%> (-36.59%)	0% <0%> (-3%)
...java/io/fabric8/maven/docker/VolumeCreateMojo.java	0% <0%> (-30%)	0% <0%> (-2%)
...java/io/fabric8/maven/docker/VolumeRemoveMojo.java	0% <0%> (-30%)	0% <0%> (-2%)
...o/fabric8/maven/docker/service/ArchiveService.java	0% <0%> (-26.67%)	0% <0%> (-1%)
...ric8/maven/docker/util/CredentialHelperClient.java	25% <0%> (-19.45%)	3% <0%> (-1%)
...a/io/fabric8/maven/docker/wait/LogWaitChecker.java	76.31% <0%> (-17.02%)	3% <0%> (-3%)
.../fabric8/maven/docker/access/log/LogRequestor.java	63.82% <0%> (-16.42%)	13% <0%> (ø)
... and 93 more

[rhuss]

@kennymacleod I agree, that -X is definitely too verbose as this is also used by the underlying HTTP service for logging all traffic. However, the POST requests can get quite verbose, too, and tbh I consider them more an internal implementation detail useful mostly for debugging the plugin itself (not a concrete build). E.g. the Docker CLI prints out build steps, but API communication only at higher logging levels.

Wdyt about introducing an dedicated 'docker.verbose.api' parameter, or even better using a value for docker.vebose like in -Ddocker.verbose=build,api ? (with build as the default ?)

[kennymacleod]

Yeah, I like that idea. Requires more changes to the logging code, obviously, but that would be a nicer solution.

[rhuss]

@kennymacleod ok, let's go this road then. Unfortunately I'm a bit loaded these days, but if you feel fancy, I would happily integrate the PR (typically at the weekends).

[rhuss]

@rohanKanojia I think the idea mention in #918 (comment) is still valid, but needs to be implemented. It's not a big deal, though, so if you want to give it a try, that would be awesome.

[rhuss]

This feature has been implemented with #1192, so closing this PR