use more efficient hashes when talking to kubernetes #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grosser started through your PRs from oldest... looks like we need a rebase here |
grosser
force-pushed
the
grosser/symbol
branch
2 times, most recently
from
99bc5f9 to
62a5aa5
Compare
|
rebased! |
cben
reviewed
Sep 24, 2020
cben
reviewed
Sep 24, 2020
cben
reviewed
Sep 24, 2020
|
I'll defer to responding to @cben before merging. |
grosser
force-pushed
the
grosser/symbol
branch
from
62a5aa5 to
2e010da
Compare
|
@cben looks good ? |
|
@grosser looks like there is a test failure. please investigate |
grosser
force-pushed
the
grosser/symbol
branch
from
2e010da to
11907e0
Compare
|
rebuild fixed it ... some random error :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more details here ManageIQ/kubeclient#251