-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align crd generator v1 and v2 output #5951
Comments
I think these lines in v1 need to be removed to align handling for JsonFormat shape with v2: kubernetes-client/crd-generator/api/src/main/java/io/fabric8/crd/generator/AbstractJsonSchema.java Lines 159 to 162 in a8fba97
Thank you! |
@manusa let's have this block 6.13 so that we have the best baseline as possible to stop development on v1. |
relates to: fabric8io#5951 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
relates to: #5951 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
I believe we've addressed all known issues. |
The v1 output should sort the required list.
Also the v1 handling for JsonFormat shape needs to leave the type as string in most cases.
v2 will use set the printer column type to be the actual property type. v1 will continue to use string in some cases.
The text was updated successfully, but these errors were encountered: